Code Review

Question 1

What the first things are you looking for when reviewing others?

Answer 1

1) Style/Formating
2) Naming
3) Test coverage ( Do we have tests?)

Question 2

What are the main part of reviewing?

Answer 2

1) Design (SOLID/Patterns)
2) Readability
3) Functionality ( does this code work as expected?)
4) Any performance/security issues
5) Documentation

Question 3

What do you need to check in the test?

Answer 3

The tests match the requirements. For
example, if the requirements are “should allow the special characters ‘#’, ‘!’ and ‘&’ in the
password field”, there should be a test using these values in the password field. If the test uses
different special characters then it’s not proving the code meets the criteria.