Code Review

Question 1

how does code review compare to unit testing

Answer 1

code review finds up to 60% of defects

unit testing finds 25%

Question 2

pros and cons of code review

Answer 2

pros:
homogenise and improve coding across team

cons:
cost
time

Question 3

what is buddy reivew

Answer 3

pairs of equal status

performed as needed

Question 4

what is team based review

Answer 4

formal structure

walkthrough- meeting

Question 5

what is formal review

Answer 5

external team comes in and performs an inspection

more senior staff

most expensive

Question 6

what is promiscuous reviewing

Answer 6

everyone review everyon

Question 7

what comments are made in code review (9)

Answer 7

defects

flaws

design

naming

smells

use of git

build

team metric effects

good practice

Question 8

give commit message conventions

Answer 8

first line: begins with imperative, less than 50 characters in length, no full stop

second line: blank

subsequent lines: less than 72 characters, descriptions

end: external references such as big tracking